feat(android): forward app hang options to NDK#5623
Draft
bitsandfoxes wants to merge 11 commits into
Draft
Conversation
Contributor
|
📲 Install BuildsAndroid
|
Contributor
Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 352.15 ms | 432.53 ms | 80.38 ms |
| e59e22a | 368.02 ms | 432.00 ms | 63.98 ms |
| 806307f | 357.85 ms | 424.64 ms | 66.79 ms |
| d364ace | 384.53 ms | 453.51 ms | 68.98 ms |
| 4c04bb8 | 307.93 ms | 362.34 ms | 54.41 ms |
| bb0ff41 | 312.86 ms | 363.78 ms | 50.92 ms |
| 91bb874 | 310.68 ms | 359.24 ms | 48.56 ms |
| 11f90db | 314.26 ms | 372.43 ms | 58.17 ms |
| f6cdbf0 | 314.19 ms | 357.59 ms | 43.40 ms |
| 8687935 | 332.52 ms | 362.23 ms | 29.71 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 3d205d0 | 1.58 MiB | 2.10 MiB | 532.97 KiB |
| e59e22a | 1.58 MiB | 2.20 MiB | 635.34 KiB |
| 806307f | 1.58 MiB | 2.10 MiB | 533.42 KiB |
| d364ace | 1.58 MiB | 2.11 MiB | 539.75 KiB |
| 4c04bb8 | 0 B | 0 B | 0 B |
| bb0ff41 | 0 B | 0 B | 0 B |
| 91bb874 | 1.58 MiB | 2.13 MiB | 559.07 KiB |
| 11f90db | 0 B | 0 B | 0 B |
| f6cdbf0 | 0 B | 0 B | 0 B |
| 8687935 | 1.58 MiB | 2.19 MiB | 619.17 KiB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📜 Description
This PR relies on getsentry/sentry-native#1823 first.
Forwards app hang options to NDK.
💡 Motivation and Context
sentry-nativenow sports an app hang capture feature, see getsentry/sentry-native#1806Hybrid SDKs can use this to let their main/UI thread emit a heartbeat. If this heartbeat times out
sentry-nativewill capture this as App Hang event.💚 How did you test it?
Not yet. Apart from unit tests that forward the options.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps